apps/server/src/routes/suggestions/generate-suggestions.ts (1)

18-39: Consider using a proper XML parser instead of regex.

Parsing XML with regex is fragile and may fail with comments, CDATA sections, nested structures, or other XML edge cases. Consider using a library like fast-xml-parser or the built-in DOMParser for more robust parsing.

🔎 Example using fast-xml-parser

+import { XMLParser } from 'fast-xml-parser';
+
 /**
  * Extract implemented features from app_spec.txt XML content
  */
 function extractImplementedFeatures(specContent: string): string[] {
-  const features: string[] = [];
-
-  // Match <implemented_features>...</implemented_features> section
-  const implementedMatch = specContent.match(
-    /<implemented_features>([\s\S]*?)<\/implemented_features>/
-  );
-
-  if (implementedMatch) {
-    const implementedSection = implementedMatch[1];
-
-    // Extract feature names from <name>...</name> tags
-    const nameRegex = /<name>(.*?)<\/name>/g;
-    let match;
-
-    while ((match = nameRegex.exec(implementedSection)) !== null) {
-      features.push(match[1].trim());
-    }
+  try {
+    const parser = new XMLParser();
+    const parsed = parser.parse(specContent);
+    
+    const implementedFeatures = parsed?.implemented_features;
+    if (!implementedFeatures) return [];
+    
+    // Handle both single feature and array of features
+    const featuresArray = Array.isArray(implementedFeatures) 
+      ? implementedFeatures 
+      : [implementedFeatures];
+    
+    return featuresArray
+      .map(f => f?.name)
+      .filter(name => typeof name === 'string')
+      .map(name => name.trim());
+  } catch (error) {
+    return [];
   }
-
-  return features;
 }

Configuration used: defaults

Review profile: CHILL

Plan: Pro

apps/server/src/routes/suggestions/generate-suggestions.ts (1)

22-43: Consider using [\s\S]*? in the name regex for consistency.

The outer regex correctly uses [\s\S]*? to match content including newlines, but the inner regex on line 34 uses .*? which doesn't match newlines by default in JavaScript. While feature names spanning multiple lines are unlikely, using /<name>([\s\S]*?)<\/name>/g would be more consistent and handle edge cases better.

Note: XML entities (e.g., <, &) and CDATA sections are not decoded/handled by this regex-based approach. This should be fine for the "controlled XML structure" mentioned in the comment, but if feature names start containing special characters that require entity encoding, consider migrating to a proper XML parser as noted in the comments.

🔎 Suggested enhancement

-    const nameRegex = /<name>(.*?)<\/name>/g;
+    const nameRegex = /<name>([\s\S]*?)<\/name>/g;

Configuration used: defaults

Review profile: CHILL

Plan: Pro